extend/pathname: use absolute path to java in write_jar_script #8163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew tests
with your changes locally?This fixes #8154. The solution is not as simple as replacing
java
with${JAVA_HOME}/bin/java
because the brace expansion of${JAVA_HOME}
will occur beforeJAVA_HOME
is assigned a value. Thus, we have to explicitlyexport JAVA_HOME
, or we could try something likeJAVA_HOME=...; exec "${JAVA_HOME}/bin/java" ...
. In any case, my point is that piggybacking off ofwrite_env_script
as it currently exists doesn't seem to be possible.To be clear, this is really only an issue for Linux users. On macOS,
/usr/bin/java
is a stub that will execute the Java thatJAVA_HOME
points to, and/usr/bin/java
should always be onPATH
.As always, I'm open to suggestions, especially on style, especially on that
export JAVA_HOME=...
Ruby glob. It's not looking too pretty.